Skip to content
Grav 2.0 is officially stable. Read the announcement →
Archive

Grav update broke Woo theme

Started by Muut Archive 10 years ago · 7 replies · 435 views
10 years ago

Seems its a bug with the lightbox script that comes with the Woo theme. It doesn't seem to like the latest jQuery 2.2.X release. Setting jQuery back to 2.1.4 in user/config/system.yaml allows it to work again:

YAML
assets:
  collections:
    jquery: system://assets/jquery/jquery-2.1.4.min.js
10 years ago

I've set the jQuery version back to 2.1.4 in the skeleton repo.

10 years ago

That's a workaround but not a solution :). It breaks in main.js on the var description=... line. Somehow that construct is not JQuery 2.2.X safe.

10 years ago

The problem is with lightbox, not Grav. That script needs to be fixed to work with jQuery 2.2.x. Not something that's Grav's fault.

10 years ago

No lightbox.js is completely fine. The Woo theme uses an ancient jquery. This itself is not causing the issue but then the theme also loads an old version of jquery-migrate. And that breaks the description line I pasted above. Once you remove jquery-migrate line 47 of base.html.twig of the template it'll work. Updating the jquery asset line to use 2.2.x is obviously also a good idea.

10 years ago

Hmm.. ok, i'll take a look. This theme is a direct port, so we didn't change any of that existing stuff.

Suggested topics

Topic Participants Replies Views Activity
Archive · by Deleted User, 9 years ago
0 1359 9 years ago
Archive · by Muut Archive, 9 years ago
2 936 9 years ago
Archive · by Muut Archive, 9 years ago
2 4066 9 years ago
Archive · by Muut Archive, 9 years ago
1 2955 9 years ago
Archive · by Muut Archive, 9 years ago
3 1121 9 years ago