Skip to content
Grav 2.0 is officially stable. Read the announcement →
Archive

Liking of oauth account to normal account

Started by Muut Archive 10 years ago · 3 replies · 336 views
10 years ago

As I know basically an oauth account with the login-oauth plugin is independent from the normal(?) account.
However since I wanted to let normal account owners log-in with the oauth method provided by facebook, I have modified small parts of the login-oauth plugin and it works well.

Do you think that this feature is valuable for the main-stream?

10 years ago

I'm certain the team would welcome pull requests. That's the ideal avenue to have this discussion because people can also look at the code.

10 years ago

Yes, I would do it. I just faithfully followed an instruction like a good kid.

"Please ask first in Gitter or in the Forum before embarking on any significant pull request (e.g. implementing features, refactoring code.."

Even though, this is not "significant" but still "implementing feature" :)

10 years ago

I think they just don't want people wasting time preparing huge pull requests that will most likely be declined. For big things, it's best to make sure the team is even open to it. For minor feature improvements, go for it.

Suggested topics

Topic Participants Replies Views Activity
Archive · by Deleted User, 9 years ago
0 1352 9 years ago
Archive · by Muut Archive, 9 years ago
2 935 9 years ago
Archive · by Muut Archive, 9 years ago
2 4064 9 years ago
Archive · by Muut Archive, 9 years ago
1 2949 9 years ago
Archive · by Muut Archive, 9 years ago
3 1119 9 years ago