Skip to content
Grav 2.0 is officially stable. Read the announcement →

Community guidelines

Please keep discussions civil and on-topic. Repeated violations may lead to a temporary ban.

Support

Direct Install Tool - "not a valid Grav package"

Solved by Michael Miller View solution

Started by Michael Miller 7 years ago · 4 replies · 666 views
7 years ago

just started getting an error message when we try to update a theme package using the Direct Upload Tool. We're on Grav v1.6.16 - Admin v1.9.10. I'm getting this on two different installs. I've tried this with several different theme packages that I know work, including the default quark theme and basic theme packages created using bin/plugin devtools new-theme

Did something change recently with the direct upload tool? Everything is working fine using the GUI "Add theme" method in the admin panel or by manually uploading and unzipping files on the server.

7 years ago Solution

so it looks like the issue is in line 191 of Grav/Common/GPM/Installer.php. $zip->getNameIndex(0) is returning the assets folder name and it looks like it should be returning the root theme folder. I got around this by throwing the blueprints.yaml and the theme php and yaml files in the assets folder for now, but it looks like this is a change in behavior for the underlying PHP ZipArchive class. I'm running PHP 7.2.19 on Ubuntu 18.04.2 and PHP 7.3.9 in development.

7 years ago

Yep if you believe this to be a bug, please report it on Github. It won't get noticed here at all.

Thank you very much for following up here though 🙂 If you feel lazy, you could just link this post from Github. It's well described here.

Suggested topics

Topic Participants Replies Views Activity
Support · by Thomas, 1 week ago
2 57 15 hours ago
Support · by Anna, 3 days ago
2 65 18 hours ago
Support · by Justin Young, 18 hours ago
1 33 18 hours ago
Support · by Duc , 1 week ago
2 68 5 days ago
Support · by Colin Hume, 1 week ago
2 60 6 days ago